Description

Fixes reverse-position failures in perps by stopping flipPosition() from sending the position entry price as the order currentPrice.

The reverse-position flow was using stale entry pricing during order placement, which could cause the provider to validate and submit the flip order against the wrong price. This change makes the flip flow rely on live provider pricing instead, and updates the related regression coverage and analytics expectation.

Changelog

CHANGELOG entry: Fixed a bug that was causing reverse position orders in Perps to fail when stale entry pricing was used during order placement

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TAT-2946

Manual testing steps

  Feature: Reverse perps position

    Scenario: user reverses an open long position
      Given the user has an open long perps position
      And the user opens the reverse position flow
      When the user confirms the reverse position order
      Then the order is submitted successfully
      And the reverse order does not fail because of stale entry pricing

    Scenario: regression coverage for flipPosition
      Given the perps controller test suite is available
      When `yarn jest app/controllers/perps/services/TradingService.test.ts -t flipPosition` is run
      Then the tests pass

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.